Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mnemonicsToEntropy mnemonic length check #301

Merged
merged 2 commits into from
Oct 29, 2021

Conversation

sche
Copy link
Contributor

@sche sche commented Jan 7, 2021

This will close #300

@skywinder
Copy link
Collaborator

Hello! thanks for this PR, please apply for a grant for this fix: https://gitcoin.co/issue/skywinder/web3swift/300/100026188

@sche
Copy link
Contributor Author

sche commented Aug 6, 2021

I applied and updated my branch with the latest changes from the develop branch.

@skywinder skywinder requested a review from BaldyAsh August 7, 2021 04:25
@BaldyAsh BaldyAsh merged commit 22db259 into web3swift-team:develop Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BIP39.mnemonicsToEntropy does not work for mnemonics of length 15, 18, 21
3 participants